fix: Use localstack/localstack-pro by default#111
Conversation
aidehn
changed the title
localstack/localstacklocalstack/localstack-pro by default
aidehn
force-pushed
the
aidehn/feat/use-pro-image
branch
from
ab7375c to
aba563e
Compare
alexrashed
left a comment
alexrashed
left a comment
There was a problem hiding this comment.
Thanks a lot for jumping on this! I really am a bit puzzled by the failing pipeline, but I agree that the pipeline is just broken (which isn't surprising given that this project hasn't seen much traction / maintenance lately).
README.md
Outdated
|
|
||
| ## Change Log | ||
|
|
||
| * v0.2.24: Make localstack/localstack-pro the default image |
There was a problem hiding this comment.
question: I guess this change will potentially break the usage of the library for some consumers (i.e. those who currently use it without an auth token). Maybe this change would be worth doing a minor bump and also reference the blog post for the image consolidation here? WDYT?
There was a problem hiding this comment.
I think that makes sense! I'll make this a minor version bump and add some reference to the blog post 👍🏼
.github/workflows/build.yml
Outdated
| run: | | ||
| set -e | ||
| nohup docker pull localstack/localstack-ext > /dev/null & | ||
| nohup docker pull localstack/localstack-pro > /dev/null & |
There was a problem hiding this comment.
nit: Given that this command can never have worked, I would actually opt to just remove it.
2 participants
Changes
localstack/localstackand opt to uselocalstack/localstack-proinstead. The prior can still be used if specified.